fix(segment-button): ensure consistent disabled state for segment-content error handling#30288
Merged
fix(segment-button): ensure consistent disabled state for segment-content error handling#30288
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
changed the title
ShaneK
approved these changes
Mar 21, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me! Seems like a solid solution 🚀
Member
|
Shouldn't this be a |
thetaPC
changed the title
thetaPC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Segment buttons do not consistently set themselves to a disabled state. When disabling them and rapidly refreshing the page, their state may vary—sometimes they appear disabled, and other times they do not.
This was due to this PR. The reason that this PR was created was due to the console errors being shown too early when segment buttons and contents were dynamically rendered.
What is the new behavior?
setTimeoutwas causing the inconsistency.componentWillLoad, it providesion-segment-contenttime to render before the console errors are thrown.Does this introduce a breaking change?
Other information
Dev build:
8.5.2-dev.11742514102.1b51674dHow to test:
npm i @ionic/react@8.5.2-dev.11742514102.1b51674d @ionic/react-router@8.5.2-dev.11742514102.1b51674dSegment Button: Unable to find Segment Content with id="content3".