Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShaneK
approved these changes
Mar 21, 2025
Member
ShaneK
left a comment
There was a problem hiding this comment.
Generally looks good, I left one comment but it's probably just a nit. Nice work 🚀
brandyscarney
approved these changes
Mar 24, 2025
Member
brandyscarney
left a comment
There was a problem hiding this comment.
Non-blocking suggestion but otherwise looks good! 🎉
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29619
What is the current behavior?
The
ionInputemits for range even when the value hasn't changed. This does not match our documentation. It should only emit when the value changes (and continuously while the user is dragging the knob).What is the new behavior?
Does this introduce a breaking change?
Other information
How to test: