Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
commented
Apr 7, 2025
Comment on lines
-15
to
-22
| .select-icon { | ||
| width: $select-md-icon-size; | ||
|
|
||
| transition: transform .15s cubic-bezier(.4, 0, .2, 1); | ||
|
|
||
| color: #{$text-color-step-500}; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I just moved this down to the select icon section.
Member
brandyscarney
left a comment
There was a problem hiding this comment.
A couple comments regarding the valid/invalid behavior since we removed the focus color from the icon.
...test/highlight/select.e2e.ts-snapshots/select-no-fill-invalid-md-ltr-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...t/test/highlight/select.e2e.ts-snapshots/select-no-fill-valid-md-ltr-Mobile-Chrome-linux.png
Show resolved
Hide resolved
brandyscarney
approved these changes
Apr 15, 2025
Member
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good! Just added some minor corrections for some comments.
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
There are a few items to note:
.has-focuswhich isn't being used anywhere withinselect.tsx. It seems that.has-focuscomes a copy and paste that wasn't updated.mdmode.mdmode.What is the new behavior?
.has-focus, removingion-focused.mdmode.mdmode.Does this introduce a breaking change?
Other information
Dev build:
8.5.4-dev.11744743162.1ec9251dSelect cannot have a focused class and an expanded class at the same time. It's one or the other.