fix(select): focus the correct selected item in an action sheet interface with a header#30481
Merged
brandyscarney merged 3 commits intoionic-team:mainfrom Jul 1, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
crazyserver
added a commit
to crazyserver/moodleapp
that referenced
this pull request
Jun 12, 2025
crazyserver
added a commit
to crazyserver/moodleapp
that referenced
this pull request
Jun 25, 2025
brandyscarney
changed the title
brandyscarney
approved these changes
Jun 30, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Thank you for the PR! I added some tests to avoid a future regression but the fix looks good! 🙂
ali205412
pushed a commit
to ali205412/moodleapp
that referenced
this pull request
Jan 26, 2026
ali205412
pushed a commit
to ali205412/moodleapp
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30480
What is the current behavior?
When using a select component with the
action-sheetinterface, aheader, and a default selected value, the action sheet opens with the wrong item focused. This happens because the focus logic usesnth-childto target the selected item, which incorrectly includes the header since it is a child element. As a result, the focus is shifted one item above the correct selection.What is the new behavior?
action-sheetwith a header from a select.Does this introduce a breaking change?
Other information
Preview