Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
reviewed
Jun 25, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
When testing the dev build on the minimal repro, I noticed that I have to tab twice from the increment button to get to the first interactable element within the modal. Is that expected? I would have thought that I only need one tab.
thetaPC
previously requested changes
Jun 27, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
Let's try to add a test to prevent regression.
brandyscarney
dismissed
thetaPC’s stale review
Maria is out on leave and cannot re-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Currently, you cannot tab into a sheet modal from outside of it (the background), even with
handleBehaviorset tocycle. This destroys the accessibility of moving from the background behind a sheet modal to the contents of a sheet modal/the drag bar to be able to cycle the size.What is the new behavior?
Now you can get into a sheet modal from outside of it and interact with its contents/drag handle when
handleBehavioris set tocycle. This opens up the accessibility of the sheet modal and allows for interacting with background elements with sheet modals open using accessibility tools like VoiceOver and TalkBack.Does this introduce a breaking change?
Other information
Relevant test screen
Dev build:
8.6.3-dev.11750971489.140836b0