test(breadcrumbs): update Playwright tests to use setContent#30518
Merged
brandyscarney merged 9 commits intomainfrom Jun 30, 2025
Merged
test(breadcrumbs): update Playwright tests to use setContent#30518brandyscarney merged 9 commits intomainfrom
brandyscarney merged 9 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
commented
Jun 30, 2025
Member
Author
There was a problem hiding this comment.
Some of these could probably be removed as screenshots and just check the count on the visible breadcrumbs. LMK if you think there are too many screenshots here.
Member
There was a problem hiding this comment.
I think a lot of these could just be programmatic tests, but also they're probably fine as visual regression tests like this. I'm fine either way. I do like this much more granular approach to visually testing them though!
1 task
ShaneK
approved these changes
Jun 30, 2025
Member
ShaneK
left a comment
There was a problem hiding this comment.
That is a lot of screenshots, but all the tests make sense to me and I really prefer this change. Great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks #30513
The latest Playwright update in #30513 exposed an issue in Safari where dynamically setting the RTL direction on the document no longer works. This causes the Breadcrumbs screenshots to fail because they are not flipping the arrow icon.
This PR converts the Breadcrumbs e2e tests to use
setContentwhich works properly with RTL and also breaks the tests up more so they aren't one giant screenshot.