fix(segment-view): scroll to correct content when height is not set#30547
Merged
brandyscarney merged 5 commits intomainfrom Jul 16, 2025
Merged
fix(segment-view): scroll to correct content when height is not set#30547brandyscarney merged 5 commits intomainfrom
brandyscarney merged 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
3 tasks
ShaneK
approved these changes
Jul 16, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
I've verified this fix works in Safari and generally approve. However, I do think the test may cause us grief in the future and recommend changing it.
core/src/components/segment-view/test/dynamic-height/segment-view.e2e.ts
Show resolved
Hide resolved
ShaneK
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30543
What is the current behavior?
On desktop Safari and Android the segment view is not switching to the right segment content when the height is dynamically set or read in as 0. This can be reproduced in the following StackBlitz on Android: https://6dhropnr-aheyyprl.stackblitz.io/
What is the new behavior?
min-heightto1pxonion-segment-contentso that it continues to work with a dynamically set heightDoes this introduce a breaking change?
Other information
Dev build:
8.6.2-dev.11752524287.1d61cd78Preview