test(react): general navigation improvement#30602
Merged
Conversation
2 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShaneK
force-pushed
the
test/react-tabs-link
branch
from
b86017b to
5d8b717
Compare
ShaneK
force-pushed
the
test/react-tabs-link
branch
from
5d8b717 to
10b0e53
Compare
ShaneK
force-pushed
the
test/react-tabs-link
branch
from
10b0e53 to
4490ce5
Compare
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
brandyscarney
approved these changes
Aug 5, 2025
Member
|
Great improvements here! ⭐ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Manual navigation in the react tests is very finnicky
What is the new behavior?
Improved react test navigation so it more consistently moves from page to page if you're manually reviewing react tests. This was done mostly by adding missing
ion-pagecomponents, but also by adding an exact match to the main component. They're still pretty shaky and not great, but better than before.Does this introduce a breaking change?
Other information