fix(segment-view): scroll and select the right item when the component is in RTL context;#30675
Merged
JoaoFerreira-FrontEnd merged 7 commits intomainfrom Sep 11, 2025
Merged
fix(segment-view): scroll and select the right item when the component is in RTL context;#30675JoaoFerreira-FrontEnd merged 7 commits intomainfrom
JoaoFerreira-FrontEnd merged 7 commits intomainfrom
Conversation
JoaoFerreira-FrontEnd
added
package: core
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- lint.fix; - reconfig the basic-tests to look into rlt too;
ShaneK
requested changes
Sep 10, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
This is a solid start, but I have some requested changes so that we can remain consistent in how we detect RTL and a bit of improved browser support.
core/src/components/segment-view/test/basic/segment-view.e2e.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Shane <shane@shanessite.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30079
What is the current behavior?
Segments (IonSegment and IonSegmentView) do not work if placed on a dir="rtl" context. If click on button, it won't slide content of the next segment.
What is the new behavior?
Does this introduce a breaking change?
Other information
Preview