Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
changed the title
brandyscarney
approved these changes
Sep 22, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
The fix looks good! I mostly have minor suggestions and questions about whether we should add more tests or not. I will defer to you on if you think we need them. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30641
What is the current behavior?
Currently, Vue modals do not emit
ionModal...events. This happened due to a change in the way the stencil output targets for Vue changed. Christian updated the overlays to support the base events, but not the component-specific events.What is the new behavior?
With this change, you'll be able to bind to the events as described in the Ionic documentation.
Does this introduce a breaking change?
Other information
Current dev build: