fix(checkbox, toggle, radio-group): improve screen reader announcement timing for validation errors#30714
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
changed the title
thetaPC
changed the title
ShaneK
requested changes
Nov 10, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Generally looking really good, just a few minor change requests
ShaneK
approved these changes
Nov 10, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me! Great work 🔥
brandyscarney
approved these changes
Nov 12, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good besides the one test issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, when an error text is shown, it may not announce itself to voice assistants. This is because the way error text currently works is by always existing in the DOM, but being hidden when there is no error. When the error state changes, the error text is shown, but as far as the voice assistant can tell it's always been there and nothing has changed.
What is the new behavior?
Does this introduce a breaking change?
Other information
Checkbox preview
Toggle preview
Radio Group preview
The flakiness on checkbox and toggle is because when a native input is present on the page, the browser will have the screen reader to be really fast when it comes to checking information. This speed ends up being too fast for
ion-checkboxto be able to add the error text. This leads to the error text not being announce consistently. There's no issue when it comes to ion-input or ion-textarea because Ionic uses the native inputs so their arias are read. There's also no issue with ion-select because we don't have a native input. It's only an issue with checkbox and the others is because it has a native input that is being hidden. So the browser sees that and speeds up the screen reader.The flakiness on radio group is because when you tab out of the last radio button, the ionBlur event is emitted by the child . This event bubbles up, but the timing is still too early for the group.