Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
I am going to leave this as a comment instead of requesting changes in case this is a non-issue.
thetaPC
commented
Oct 10, 2025
| * @returns 'none' if inside ion-menu or if condensed in md | ||
| * mode, otherwise 'banner'. | ||
| */ | ||
| export const getRoleType = (isInsideMenu: boolean, isCondensed: boolean, mode: 'ios' | 'md') => { |
Contributor
Author
There was a problem hiding this comment.
We'll might have to update the mode to theme in next.
ShaneK
approved these changes
Oct 15, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Nice work! I also especially like the added tests 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
As per accessibility guidelines, there should only be one banner landmark per page. A condensed header creates two banner landmarks since 2
ion-headercomponents are required on the page.ion-headerrenders with arole="banner"by default (when not inion-menu).The visual effect of the condensed header is achieved by rendering two distinct header components. Because both components exist in the code at the same time and both have
role="banner", they create a duplicate landmark announcement for screen readers. This leads to a violation with the accessibility guidelines.What is the new behavior?
noneorbannerbased off the header's active state.Does this introduce a breaking change?
Other information
Preview