Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
changed the title
brandyscarney
approved these changes
Oct 21, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Just a few requests but looks great! Nice work catching & fixing this.
ShaneK
requested changes
Oct 21, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looking really good, just a few change requests
|
|
||
| configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { | ||
| configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | ||
| test.describe(title('toggle: ionChange'), () => { |
Member
There was a problem hiding this comment.
It looks like there's no ionBlur test for toggle like there is for Checkbox. I think it may be worth adding just in case, but up to you
Member
There was a problem hiding this comment.
Sorry, I just saw Brandy had already mentioned this. My bad. Great work!
Co-authored-by: Shane <shane@shanessite.net>
Co-authored-by: Shane <shane@shanessite.net>
brandyscarney
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
ionFocusandionBlurare not being emitted for checkbox and toggle.What is the new behavior?
onFocusandonBlurtoHostonFocus,onBlur, andonChange.ionBlursince Playwright browsers aren't acting like native browsers when it comes to tabbing.Does this introduce a breaking change?
Other information
Dev build:
8.7.7-dev.11761071592.1d1b804d