fix(datetime): ensure datetime is shown when intersection observer fails to report visibility#30793
Merged
fix(datetime): ensure datetime is shown when intersection observer fails to report visibility#30793
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
requested changes
Nov 18, 2025
core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts
Outdated
Show resolved
Hide resolved
core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts
Outdated
Show resolved
Hide resolved
|
@ShaneK The dev build does correctly resolve the problem for me 👍 Thanks providing a fix 🙇 |
brandyscarney
changed the title
bhojkapderas
approved these changes
Nov 20, 2025
brandyscarney
approved these changes
Nov 20, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Small request to link the follow-up investigative ticket & I also left some other feedback on the Jira ticket. Looks good though!
brandyscarney
changed the title
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30706
What is the current behavior?
Due to some recent unknown changes, the intersection observer for date time no longer reliably fires, especially in mobile views.
What is the new behavior?
In this PR, we're adding a visibility check after everything has had a chance to render to make sure we're setting up properly even if the intersection observer has failed to trigger for some reason.
Does this introduce a breaking change?
Other information
Since the intersection observer is being set up after a
raf, it's possible something got introduced to make the initial setup slower for some reason, causing timing issues. I think we should do a more thorough investigation into the cause of this problem when we have more time.This PR also adds tests to verify the new fallback works properly.
Current dev build: