fix: update xmlns placement #1433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for raising the PR, we have incorporated this patch into #1447 and will release it soon. |
Author
|
@christian-bromann That PR doesn't appear to include these changes. This updates 82 files and that only includes 52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated
xmlns="http://www.w3.org/2000/svg"to be the first attribute for every SVG file, verified via regex:<svg(?!\sxmlns)Removed instances of
id="icons"andid="Layer_1" data-name="Layer 1"Screenshots
Before - missing icons, invalid
ionicons.symbols.svgAfter - all icons present, valid
ionicons.symbols.svgNotes
Fixes: #1432