fix(angular-standalone): enable auto import for angular standalone#1874
Open
luisbytes wants to merge 1 commit intoionic-team:mainfrom
Open
fix(angular-standalone): enable auto import for angular standalone#1874luisbytes wants to merge 1 commit intoionic-team:mainfrom
luisbytes wants to merge 1 commit intoionic-team:mainfrom
Conversation
…lone components in VS Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1873
In the Angular standalone starter, the auto import feature in VS Code was not working for Ionic components.
This was caused by the
.vscode/settings.jsonconfiguration, which excluded"@ionic/angular"entirely fromtypescript.preferences.autoImportFileExcludePatterns.That exclusion prevented VS Code from suggesting imports not only from the barrel file (
@ionic/angular), but also from subpaths such as:What’s changed
Instead of excluding the entire
@ionic/angularpackage, this PR refines the exclusion list after reviewing the barrel file to identify which internal paths are actually re-exported.As a result, only those specific internal paths are excluded:
Result
Auto import in VS Code now correctly works for:
while still preventing imports from the internal subpaths of
@ionic/angular.