Merged
Conversation
- Removed unnecessary inline specifiers for member functions in spatial_hash.hpp. - Initialized member variables in spatial_hash.hpp to default values. - Updated assertions to check for emptiness instead of size in various locations. - Changed shared pointer parameters to use const references for efficiency. - Simplified conditional checks and improved readability in multiple files. - Replaced manual checks for negative values with std::max in collision_mesh.cpp. - Enhanced clarity in comments and function signatures across several files. - Updated distance type enums to use uint8_t for better memory efficiency. - Improved consistency in function parameter naming and usage. - Cleaned up unused parameters and improved function documentation.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 96.03% 95.98% -0.05%
==========================================
Files 105 104 -1
Lines 8100 8077 -23
==========================================
- Hits 7779 7753 -26
- Misses 321 324 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Static Analysis and Code Style Improvements:
.clang-tidyconfiguration file with a comprehensive set of checks, exclusions, naming conventions, and options to enforce modern C++ practices and treat all warnings as errors..github/workflows/clang-tidy-check.yml) to automatically run Clang-Tidy on relevant files for every push and pull request, improving code quality and review automation.Refactoring for Clarity and Safety:
size() == 0toempty()throughout broad phase modules, improving readability and safety.Variable and Member Initialization:
one_div_voxelSizetoone_div_voxel_sizeand updated all usages for clarity and consistency.vertex_idsinAABBandm_cell_sizeinHashGridto safe default values to prevent uninitialized usage.Minor Code Modernization:
inlinekeywords from class member functions, and improved parameter naming for clarity and documentation.