Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 149 149
Lines 23748 23748
Branches 797 797
=======================================
Hits 23132 23132
Misses 616 616
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Can you also add a note about CUDA support to the |
Contributor
Author
|
Now IPC will set CMAKE_CUDA_ARCHITECTURES to native if not specified. I also update READMD, build doc, and bump minimal cmake version to 3.24 across the repo. This should work in our CI/CD since Ubuntu 24.04 comes with cmake 3.28 by default. |
Corrected punctuation and grammar in the README file for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR streamlines the CMake CUDA setup by:
Since cuda code is sensitive to environment changes (i.e. IPC fails to build on CUDA 13.0+), enabling it implicitly can create surprises for its consumer. As a library, CUDA build should be guarded behind a cmake option.
Also, ipc-toolkit currently inherits the cuda architecture from Scalable CCD, which defaults to "native" if not defined. Instead, we should handle this explicitly.