Merged
Conversation
zfergus
approved these changes
Dec 9, 2025
zfergus
reviewed
Dec 9, 2025
| ++unused_vert_id; | ||
| } else { | ||
| boxes->vertices[i].vertex_ids.z = vertex_boxes[i].vertex_ids[2]; | ||
| } |
Member
There was a problem hiding this comment.
If you want you can use the same logic as Scalable CCD:
Vertex Box: (i, -1, -1) -> (i, -i-1, -i-1)
Edge Box: (i, j, -1) -> (i, j, -i - 1)
Triangle Box: (i, j, k) -> (i, j, k)
Member
There was a problem hiding this comment.
const auto [vi, vj, vk] = vertex_boxes[i].vertex_ids;
assert(vi >= 0);
boxes->vertices[i].vertex_ids.x = vi;
boxes->vertices[i].vertex_ids.y = vj >= 0 ? vj : (-vi - 1);
boxes->vertices[i].vertex_ids.z = vk >= 0 ? vk : (-vi - 1);
Contributor
Author
There was a problem hiding this comment.
Can vi be 0? Maybe the assert should be assert(vi >= 0);
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 97.40% 97.41%
=======================================
Files 149 149
Lines 23748 23748
Branches 797 798 +1
=======================================
+ Hits 23132 23133 +1
+ Misses 616 615 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix vertex id assignment logic in
SweepAndTiniestQueue.Type of change
How Has This Been Tested?
The broadphase unit test now pass.
Test Configuration:
Checklist