fix(routing): defensive nil checks for multiaddr handling #1081
+31
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belt-and-suspenders defense against corrupted address data: - types/ipfs.go: Multiaddr.MarshalJSON returns null for nil - contentrouter: filters nil addresses when building AddrInfo Should help with ipfs/kubo#11116
3 tasks
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1081 +/- ##
==========================================
+ Coverage 61.09% 61.14% +0.05%
==========================================
Files 264 264
Lines 26222 26225 +3
==========================================
+ Hits 16020 16035 +15
+ Misses 8524 8515 -9
+ Partials 1678 1675 -3
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
gammazero
approved these changes
Dec 20, 2025
- extract filterAddrs() to deduplicate nil-filtering logic - preallocate slice per review feedback - extend nil multiaddr protection to FindPeer and GetClosestPeers - update test to expect empty slices instead of nil addresses review feedback on #1081
gammazero
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Belt-and-suspenders defense against corrupted address data:
Should help with ipfs/kubo#11116