Skip to content

Conversation

@dynst
Copy link

@dynst dynst commented Dec 17, 2025

@dynst dynst requested review from a team and lidel as code owners December 17, 2025 20:05
@welcome
Copy link

welcome bot commented Dec 17, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging on best-effort basis, which may take multiple business. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@lidel lidel changed the title migrate to neostandard refactor: migrate to neostandard Dec 17, 2025
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dynst thank you for opening this. unfortunately something broke in this PR and tests no longer pass -- would you have bandwidth to investigate and address?

(https://github.com/ipfs/ipfs-desktop/actions/runs/20315749529/job/58371418486?pr=3032#step:15:16 looks like linting minified code or something)

@lidel lidel added the need/author-input Needs input from the original author label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need/author-input Needs input from the original author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace standard with neostandard

2 participants