-
Notifications
You must be signed in to change notification settings - Fork 902
refactor: update code for ESM compatibility #3033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging on best-effort basis, which may take multiple business. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dynst thank you for opening this. unfortunately something broke in this PR and tests no longer pass -- would you have bandwidth to investigate?
if this turns out a laborious effort, we may need to go with more surgical ESM support.
fwiw i had attempted "esm loader" draft in (wip) #3034 to avoid full ESM switch and changing too much, but it does not seem to be working (dynamic imports dont work in main electron thread)
With ESM, all exported values need to have a name,