fix: prevent port replacement from corrupting IP addresses #3035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the naive string replacement in checkPorts() could corrupt multiaddr
IP addresses when the port number appeared in the IP portion.
for example, replacing port `0` in `/ip4/127.0.0.1/tcp/0` would match
the first `0` in `127.0.0.1`, producing `/ip4/127.5001.0.1/tcp/0`.
this caused "invalid ip address" errors on startup when ports were busy.
fix by using `/tcp/${port}` pattern to match only the port component.
ref: https://discuss.ipfs.tech/t/invalid-ip-address/19925
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the naive string replacement in checkPorts() could corrupt multiaddr IP addresses when the port number appeared in the IP portion.
for example, replacing port
0in/ip4/127.0.0.1/tcp/0would match the first0in127.0.0.1, producing/ip4/127.5001.0.1/tcp/0.this caused "invalid ip address" errors on startup when ports were busy.
fix by using
/tcp/${port}pattern to match only the port component.ref: https://discuss.ipfs.tech/t/invalid-ip-address/19925