Conversation
Introduces a new grid view mode for the files page, allowing users to switch between list and grid views. Includes: - New FilesGrid component - View mode toggle buttons - Shared props between list and grid views - Updated rendering logic to support both view modes
…shortcut modal to context
- Added a new "General" shortcut label in the app localization. - Refactored shortcut handling in the FilesGrid and FilesList components to use refs for focused file management. - Improved keyboard shortcut handling by integrating the useShortcuts hook for better organization and functionality. - Adjusted the order of shortcut groups in the shortcut modal for improved user experience.
|
Hi @SgtPooki, I’ve made an attempt at addressing the issue and would appreciate your review when you have a moment. |
It might take me a while to get to review this one thoroughly. |
|
No worries at all, I understand. Thanks for the heads-up, and I’ll be around if you need anything clarified when you get to it! |
SgtPooki
left a comment
There was a problem hiding this comment.
Thanks again for this @george-hub331, this is great. Sorry it took me so long to only partially get through it 😅
I only got through 16/26 files but it's looking pretty useful. Some changes requested, and some comments could use some discussion.
|
So that you know, I'm having some ts migration issues while adding the diagnostics screen in #2392. I am considering allowing I want all new code to be typechecked so we're not exacerbating the problem of untyped code, but without needing new PRs to enlarge unnecessarily.. |
|
Hey @SgtPooki, sorry for the delays👀 Wrapped up all pending requests, modularized the shortcut API, added refs, and replaced every document.getElementById with a ref. |
Fixes #2350
Summary
This PR adds a centralized keyboard shortcuts system using React Context, making it easier to manage and customize keyboard shortcuts throughout the application.
Changes
Implementation Details
New improvements
Short Demo
demo.mp4