fix: Typescript Migration, localstorage.js bundler to context#2410
fix: Typescript Migration, localstorage.js bundler to context#2410
Conversation
|
@SAHU-01 thanks for your contribution.. However, this local storage file doesn't seem to be an actual redux-bundler bundle. We could probably just move the file as-is to src/lib/local-storage.. no need to use context or context-bridge for this at all as they're just function wrappers for localStorage. |
Thank you for your review @SgtPooki , I'll do the needful and update this PR asap! |
…om/SAHU-01/ipfs-webui into migration/local-storage-to-context
SgtPooki
left a comment
There was a problem hiding this comment.
mostly looks good except some breakage of indentation
Following the REDUX-BUNDLER-MIGRATION-GUIDE.md this PR migrates local-storage.js bundler to fix part of #2349
Changes:
->src/bundles/pinning.js
->src/bundles/gateway.js
->src/bundles/ipns.js
->src/bundles/ipfs-provider.js
Pattern: Replaced import { readSetting, writeSetting } from './local-storage.js' with context bridge selectors using createContextSelector('localStorage').
Testing: App loads without localStorage-related console errors. All localStorage functionality preserved.
Reviewer:
@SgtPooki