Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the REDUX-BUNDLER-MIGRATION-GUIDE.md this PR migrates local-storage.js bundler to fix part of #2349
Changes:
Created: src/contexts/tours-context.tsx - React context managing tour state and tooltip preferences
Updated: src/App.js - Added ToursProvider to app hierarchy
Migrated components from redux-bundler HOCs to React hooks:
✅ src/files/FilesPage.js - Removed withTour HOC, uses useTours() hook, creates local handleJoyrideCallback
✅ src/peers/PeersPage.js - Removed withTour HOC, uses useTours() hook, creates local handleJoyrideCallback
✅ src/welcome/WelcomePage.js - Removed withTour HOC, uses useTours() hook, creates local handleJoyrideCallback
✅ src/settings/SettingsPage.js - Removed withTour HOC, wrapper component with useTours() hook
✅ src/status/StatusPage.js - Removed withTour HOC, uses useTours() hook, creates local handleJoyrideCallback
✅ src/App.js - Added wrapper component for tooltip functionality
Updated: src/components/tour/withTour.js - Now uses context internally (kept for potential future use)
Removed:
✅ src/bundles/tours.js from bundle composition
✅ withTour HOC dependency from all migrated components
Pattern:
Reviewer:
@SgtPooki