Skip to content

Conversation

@george-hub331
Copy link
Contributor

@george-hub331 george-hub331 commented Feb 17, 2025

Add link to check.ipfs.network on block fetch failure

This PR adds a link to check.ipfs.network when a block cannot be retrieved, allowing users to investigate why a block was unable to be fetched.

Changes

  • Added a link to check.ipfs.network in the error component when a block fetch fails
  • Modified the error class to expose the CID property
  • Added translations for the new link text

Testing

The changes can be tested by:

  1. Attempting to fetch a non-existent or unavailable CID
  2. Verifying that the error message appears with the new link
  3. Clicking the link to ensure it properly redirects to check.ipfs.network with the correct CID

@george-hub331 george-hub331 requested a review from a team as a code owner February 17, 2025 11:55
@welcome
Copy link

welcome bot commented Feb 17, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove all translation changes from this PR except for the addition of the new property in the public/locales/en/explore.json?

we can update translations via a separate PR and the transifex service.

@george-hub331 george-hub331 changed the title feat: add link to check.ipfs.network on block fetch failure - Fixes #447 feat: add link to check.ipfs.network on block fetch failure Mar 11, 2025
@george-hub331 george-hub331 force-pushed the feat/add-check-ipfs-network-link branch from 5cd11ae to 8d1eea6 Compare March 11, 2025 23:19
@george-hub331 george-hub331 force-pushed the feat/add-check-ipfs-network-link branch from 8d1eea6 to 5cbde30 Compare March 11, 2025 23:22
@george-hub331
Copy link
Contributor Author

@SgtPooki i've been able to make requested changes, pending your review

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but I made a quick edit to center the error message and move the troubleshooting tips to it's own dumb component.

@SgtPooki SgtPooki merged commit a6dc200 into ipfs:master Apr 16, 2025
17 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 16, 2025
## [8.2.0](v8.1.4...v8.2.0) (2025-04-16)

### Features

* add link to check.ipfs.network on block fetch failure ([#469](#469)) ([a6dc200](a6dc200))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SgtPooki
Copy link
Member

this fixes a task for ipshipyard/roadmaps#11. we need to deploy to explore.ipld.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants