Skip to content

Conversation

@silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Jun 19, 2025

Much like in ipinfo/python#110 I decided to create a separate class to call the Lite API as the returned object is different from the Core API.

The tests I wrote are different from the existing ones as they actually call the API and don't rely on the test app so I had to change the tests workflow for them to properly run.

We need to update the IPINFO_TOKEN secret as it's causing CI to fail and is probably expired.

@silvanocerza silvanocerza requested a review from max-ipinfo June 19, 2025 16:44
@silvanocerza silvanocerza self-assigned this Jun 19, 2025
@linear
Copy link

linear bot commented Jun 19, 2025

@max-ipinfo
Copy link
Contributor

max-ipinfo commented Jun 19, 2025

@silvanocerza I fixed the problem with the old IPINFO_TOKEN value.

Confirming that tests are now passing in Github Actions.

@silvanocerza silvanocerza merged commit 5242317 into master Jun 20, 2025
7 of 13 checks passed
@silvanocerza silvanocerza deleted the silvano/eng-283-add-lite-api-support-to-ipinfonode branch June 20, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants