Made IOPubThread constructor backward compatible #1492
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainCorlay
approved these changes
Jan 30, 2026
ianthomas23
approved these changes
Jan 30, 2026
Collaborator
ianthomas23
left a comment
ianthomas23
left a comment
There was a problem hiding this comment.
LGTM.
I am going to merge and make prerelease 7.2.0a1 so that this can be tested downstream. We won't make an actual release 7.2.0 until @minrk has confirmed this is OK.
Member
|
Yes, this is perfect, thank you! I have some suggestions for minor improvements that I've been working on in my own PR, but they don't need to block anything, I think, since I've had other things preventing me from finishing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the backward incompatibility introduced in #1482
@minrk this should allow to publish a minor update instead of a major one, let me know if I missed something.