Allow default ignition template to be overridden #536
Conversation
asergeant01
requested review from
afritzler,
nagadeesh-nagaraja and
stefanhipfel
github-actions
bot
added
size/XL
documentation
nagadeesh-nagaraja
left a comment
nagadeesh-nagaraja
left a comment
There was a problem hiding this comment.
may be we can make sure that the changes will not break the existing workflows in metal-api?
asergeant01
force-pushed
the
default-ipxe-template
branch
from
321532c to
b9ff7d4
Compare
|
I got two questions, sorry if I am missing something obvious:
|
|
My use case is trying to run e2e locally with a virtualised environment. I Intercept redfish calls to start server (instead creates a qemu vm) and likewise with stop server (stops the qemu vm). This allows me to observe the pxe boot and the metal probe execution - however, there are obviously some modifications I need to make to the ignition file and currently there is no way to override the hardcoded default. This implementation should not change the default behaviour of using the hardcoded ignition template, but add the option to use one provided from a configmap. Regarding could it be mounted and read - absolutely if you think this is a better approach. Curious as to the benefits of this approach? |
nagadeesh-nagaraja
left a comment
nagadeesh-nagaraja
left a comment
There was a problem hiding this comment.
LGTM from my side. please check on others comment if this works :)
asergeant01
force-pushed
the
default-ipxe-template
branch
3 times, most recently
from
3ea6950 to
b234a2e
Compare
It would simply the code, because you only have to |
asergeant01
force-pushed
the
default-ipxe-template
branch
from
b234a2e to
f8de4dd
Compare
asergeant01
force-pushed
the
default-ipxe-template
branch
2 times, most recently
from
93c1551 to
4bca890
Compare
asergeant01
force-pushed
the
default-ipxe-template
branch
from
4bca890 to
772cee3
Compare
asergeant01
force-pushed
the
default-ipxe-template
branch
from
946f988 to
441cb68
Compare
afritzler
changed the title
| @@ -1,51 +0,0 @@ | |||
| // SPDX-FileCopyrightText: 2025 SAP SE or an SAP affiliate company and IronCore contributors | |||
There was a problem hiding this comment.
Why moving those helper into a new file?
There was a problem hiding this comment.
So this was my attempt at reducing the sporadic test failures by making the helper a test in itself so I'd have access to the k8sclient. I'm going to revert this.
| LABEL source_repository="https://github.com/ironcore-dev/metal-operator" | ||
| WORKDIR / | ||
| COPY --from=manager-builder /workspace/manager . | ||
| COPY config/manager/ignition-template.yaml /etc/metal-operator/ignition-template.yaml |
There was a problem hiding this comment.
Can't we just load the in-code var as a default - meaning leaving the existing behavior if no override file is provided?
There was a problem hiding this comment.
We could, however I think it's clearer for an end user that the discovery ignition is always loaded from a file. To me it reduces ambiguity, easier debugging and reduces code.
Proposed Changes
The current default ignition is hardcoded. This change allows it to be optionally overridden by a ConfigMap.