Add early returns on resource changes in ServerReconciler

[nagadeesh-nagaraja]

Proposed Changes

Server Reconciler avoid double reconciliation logic. This helps avoid overloading BMC, multiple reconcile during sequencial l update

[Nuckal777]

Thanks, could you please remove the changes of #540 from this PR?

[nagadeesh-nagaraja]

Thanks, could you please remove the changes of #540 from this PR?

I will rebase once that PR merges. this PR will fail unit tests without the test fixes in the other PR :D

[afritzler]

Why not doing this right after the ensureServerStateTransition call?

[afritzler]

I would suggest doing something like that here:

if modified, err := r.ensureServerStateTransition(ctx, log, bmcClient, server); err != nil || modified {
   return ctrl.Result{}, err
}

[nagadeesh-nagaraja]

because we like to update the status field before ending the reconcile... as use the status field to make decision in beginning of reconcile loop, i wanted to update the status before next reconcile.
I know updating status might modify the CRD by itself.. but I think that next improvement to tackle, what do you think?