Skip to content

Add DNS record creation support for servers #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stefanhipfel wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add DNS record creation support for servers #546

stefanhipfel wants to merge 8 commits into from

Conversation

@stefanhipfel
Copy link
Contributor

@stefanhipfel stefanhipfel commented Dec 2, 2025 •
edited
Loading

Proposed Changes

  • Introduced DNSRecordTemplateConfigMap field in BMCReconciler to specify the ConfigMap for DNS record templates.
  • Implemented logic to create DNS records for servers during discovery if the ConfigMap is configured.
  • Added a new ConfigMap for DNS record templates with example structure.
  • Enhanced unit tests to verify DNS record creation functionality.

@stefanhipfel
Add DNS record creation support for servers using a template from Con…
187a46a 
…figMap

- Introduced DNSRecordTemplateConfigMap field in BMCReconciler to specify the ConfigMap for DNS record templates.
- Implemented logic to create DNS records for servers during discovery if the ConfigMap is configured.
- Added a new ConfigMap for DNS record templates with example structure.
- Enhanced unit tests to verify DNS record creation functionality.
@github-actions github-actions bot added the size/L label Dec 2, 2025
@stefanhipfel stefanhipfel changed the title Add DNS record creation support for servers using a template from Con… Add DNS record creation support for servers using a template from cm Dec 2, 2025
afritzler
afritzler requested changes Dec 2, 2025
View reviewed changes
@afritzler afritzler added the enhancement New feature or request label Dec 2, 2025
@github-actions github-actions bot added api-change documentation Improvements or additions to documentation labels Dec 2, 2025
Nuckal777
Nuckal777 requested changes Dec 3, 2025
View reviewed changes
afritzler
afritzler requested changes Dec 9, 2025
View reviewed changes
@afritzler
Copy link
Member

afritzler commented Dec 9, 2025

Btw. it would be also good if we update the documentation of the metal-operator describing how to use that feature. I would suggest adding a configuration.md under https://github.com/ironcore-dev/metal-operator/tree/main/docs/usage

@afritzler afritzler changed the title Add DNS record creation support for servers using a template from cm Add DNS record creation support for servers Dec 15, 2025
@stefanhipfel
Add DNS record template support and update BMC reconciler
1cb6500 
- Introduced LoadTemplate function to load DNS record templates from files.
- Updated BMCReconciler to use DNSRecordTemplate instead of DNSRecordTemplatePath.
- Enhanced documentation to include usage of DNS record templates.
- Added tests for DNS record template loading.
@stefanhipfel stefanhipfel requested a review from a team as a code owner December 16, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nuckal777 Nuckal777 Nuckal777 requested changes

@afritzler afritzler afritzler requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

api-change area/metal-automation documentation Improvements or additions to documentation enhancement New feature or request size/L

Projects

Roadmap
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stefanhipfel @afritzler @Nuckal777 @hardikdr