Skip to content

Improve watch setup in ServerMaintenance reconciler #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afritzler wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improve watch setup in ServerMaintenance reconciler #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e89a886
Improve watch setup in `ServerMaintenance` reconciler
afritzler Dec 10, 2025
ed756be
Address review feedback
afritzler Jan 8, 2026
eb5b013
Fix enqueue method and potential nil deref
afritzler Jan 8, 2026
6a0d7b1
Remove redundant nil checks
afritzler Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/controller/index_fields.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,18 @@ func RegisterIndexFields(ctx context.Context, indexer client.FieldIndexer) error
return err
}

if err := indexer.IndexField(ctx, &metalv1alpha1.ServerMaintenance{}, serverRefField, func(rawObj client.Object) []string {
maintenance, ok := rawObj.(*metalv1alpha1.ServerMaintenance)
if !ok {
return nil
}
if maintenance.Spec.ServerRef != nil && maintenance.Spec.ServerRef.Name != "" {
return []string{maintenance.Spec.ServerRef.Name}
}
return nil
}); err != nil {
return err
}

return nil
}
Loading
Loading