Skip to content

Conversation

@MicrocontrollersDev
Copy link
Contributor

Unfinished and largely untested. just pushing the porting i had done, not sure if youve done anything yourself but feel free to close and/or use anything from this pr

Some notes:

  • in your remove bugs that have been fixed in the last snapshot cycle MC-147659 was incorrectly removed so I added it back
  • MC-267469 is fixed in vanilla some time in the 1.21.9 snapshot cycle but it hasnt been marked fixed. left a comment, but im not about to figure out which snapshot fixed it so i gave it a general 1.21.9 fix version
  • I just commented out the part from NoYaclScreen since i honestly dont know what thats for
  • MC-2025 was removed in your commit and the version fix said 2017 on the website, idk what thats about but i also removed the helper class for it, i'll assume its fixed and had no reason to be in here
  • MC-577 i was unable to capture the slot using local? not sure why
  • MC-201723 i have no idea. they now display as clicked in vanilla but will never unclick. idk how to fix that rn i just commented it out

@isXander
Copy link
Owner

Thank you for your contribution - I referenced it in my final pass of my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants