Fixes Warp kernel compilation error in Fabric backend#4539
Open
emmanuel-ferdman wants to merge 1 commit intoisaac-sim:mainfrom
Open
Fixes Warp kernel compilation error in Fabric backend#4539emmanuel-ferdman wants to merge 1 commit intoisaac-sim:mainfrom
emmanuel-ferdman wants to merge 1 commit intoisaac-sim:mainfrom
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
Greptile OverviewGreptile SummaryThis PR fixes a runtime compilation error in the Fabric backend by replacing Key changes:
Technical correctness: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client as Client Code
participant Kernel as compose_fabric_transformation_matrix_from_warp_arrays
participant Warp as Warp Library
participant Fabric as Fabric Backend
Client->>Kernel: Call with positions, orientations, scales
Kernel->>Kernel: Get fabric index from mapping
Kernel->>Fabric: Read current transformation matrix
Kernel->>Kernel: Decompose to get existing values
Kernel->>Kernel: Update position, rotation, scale from input arrays
Kernel->>Warp: wp.quat_to_matrix(rotation)
Warp-->>Kernel: 3x3 rotation matrix
Kernel->>Kernel: Apply scale to each column of rotation matrix
Note over Kernel: m00=rot[0,0]*scale[0], m01=rot[0,1]*scale[1], etc.
Kernel->>Kernel: Construct 4x4 matrix with scaled rotation + position
Kernel->>Warp: wp.mat44f(...) then wp.transpose()
Warp-->>Kernel: Transposed matrix (column-major)
Kernel->>Warp: wp.mat44d() cast to double precision
Warp-->>Kernel: Final transformation matrix
Kernel->>Fabric: Write matrix to fabric_matrices[fabric_index]
Kernel-->>Client: Transform updated in Fabric
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Fabric backend uses
wp.transform_composeto build transformation matrices, but this function was added in Warp 1.7. Isaac Sim 4.5 ships with Warp 1.5, so the kernel fails to compile when callingset_world_poseson cameras or other prims with Fabric enabled. This PR replaces the missing function with inline matrix math usingwp.quat_to_matrix, which exists in Warp 1.5.Fixes #4529
Type of change
Screenshots
N/A - this is a runtime error fix, no visual changes.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there