New customization options for when there are more than max-labels items#376
Open
miikka wants to merge 2 commits intoisteven:masterfrom
Open
New customization options for when there are more than max-labels items#376miikka wants to merge 2 commits intoisteven:masterfrom
miikka wants to merge 2 commits intoisteven:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to have some extra control over text in the dropdown when there are more than
max-labelsitems, so I made the following changes:more-text, so instead of "foo, bar, ... (5)" you can have "foo, bar (CLICK FOR MORE) (5)"show-counterfor always hiding the counter ("foo, ... (5)" -> "foo, ...")I tried to made it so that the defaults are as before. I hope that editing the HTML files was the right way to add the documentation for the new attributes.