Open
Conversation
jack_get_time() returns microseconds, not seconds. See: https://jackaudio.org/api/group__TimeFunctions.html#ga3b26460e62a56cf012e9075dcb1b6294
Contributor
Author
|
Note: the build failure in CI is not caused by this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The help text of jack_load_test says:
-t, --timeout Wait timeout in secondsBut the time is interpreted as microseconds:
See:
jack-example-tools/tools/load_test.c
Line 49 in 767acf0
which calls
jack_get_time()https://jackaudio.org/api/group__TimeFunctions.html#ga3b26460e62a56cf012e9075dcb1b6294
but
jack_get_timereturns microseconds. This PR just updates the help text to describe the current behaviour.