Count disappeared macro uses via origin property #751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The identifier usage analyzer only counted identifiers in expanded code, missing macros that expand away completely. For example:
Changes
Extract identifiers from origin properties: Added
origin-property-identifiersto recursively extract identifiers from the'originsyntax property, which records disappeared macro uses. Handles property structures (single syntax, lists, nested pairs).Visit all syntax objects: Modified
usage-site-identifiersto usesyntax-search-everythingto check origin properties on all nodes during traversal.Phase labeling: Applied phase labels to origin-extracted identifiers for correct binding matching across phases.
Performance Impact
Large macro expansions may exceed the 100ms analyzer timeout (2 test failures in for-loop-shortcuts-test.rkt). Trade-off prioritizes correctness; optimization possible via lazy stream operations.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.