-
Notifications
You must be signed in to change notification settings - Fork 56
CI: Update maven plugins and release pipeline - migrate from OSSRH to central publishing #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM. Do you think this warrants re-publishing the 2.10.0 tag so we have confidence by "testing" this now or are you comfortable with shelving this until 2.10.1, etc? |
We can't really re-publish the same version of artifact to Maven Central, but I have just executed the pipeline on test branch and pushed a 2.10.1-alpha1. It is pending manual confirmation both in Github releases page as well as in Central Publishing portal, so it seems to work as expected. I guess we don't have to verify the actual publish action on their side just yet. |
This makes perfect sense... I think I was under the false impression that it wouldn't publish to Maven under
Not making any criticism though, this is what the patch process is for, so it's all working as expected. We may very well have other regressions we won't know until users deploy. |
Is there an easy way to provide a build that includes #189 so that I can test it with macOS notarization? |
|
After running this action from Github on a specific branch, you end up with another branch where new binaries are pushed. If you are happy with the result, the latter branch may be merged to master (ideally without rebase/squash to preserve the relation between CI job and the resulting commit). If there is a problem, or a need to retry, drop the autogenerated, and retry after fixing it. |
Thanks. This may seem obvious but if you could help me and other collaborators understand how to run this step for the future, that would be greatly appreciated. WRT testing #189, that seems off-topic now, but to finish the conversation... I can build a jar locally from |
Notarization is fixed with the merge of #189. Conducting pre-submission checks for <redacted>.pkg and initiating connection to the Apple notary service...
Submission ID received
id: d2ff4d2c-abcd-4afe-a1aa-5ba2b71ac818
Upload progress: 100.00% (99.3 MB of 99.3 MB)
Successfully uploaded file
id: d2ff4d2c-abcd-4afe-a1aa-5ba2b71ac818
path: <redacted>.pkg
Waiting for processing to complete.
+ Current status: Accepted.................
Processing complete
id: d2ff4d2c-abcd-4afe-a1aa-5ba2b71ac818
+ status: Accepted
Processing: <redacted>
Processing: <redacted>
+ The staple and validate action worked! |
I have updated the Wiki. |
Thanks! |
08e4fc8 to
83f65f8
Compare
OSSRH, a service we used in the past to publish JSSC releases to Maven Central, announced that it's reaching its end of life, and users should migrate to the successor service - Central Portal. Instructions are available at this link.
For JSSC this means:
In this PR I sorted out the code side changes, plus a few minor additions: