MediaSend update 1 : Moved fragment UI to compose #4

jbsession · 2025-12-19T09:19:43Z

Moved the old Fragment XMLs to Compose.

New ComposeFragments are created to replace the old fragments for the MediaSendActivity.

Part 2 in progress : MediaSendFragment UI to compose.

ThomasSession · 2025-12-21T22:19:26Z

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/MediaPickerFolderScreen.kt

+) {
+
+    // span logic: screenWidth / media_picker_folder_width
+    val folderWidth = dimensionResource(R.dimen.media_picker_folder_width)


You probably want to port this into our compose Dimension.kt instead. You can remove media_picker_folder_width and other related xml dimensions if they are not needed or moved to the kt file instead.

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+                modifier = Modifier
+                    .align(Alignment.BottomCenter)
+                    .fillMaxWidth()
+                    .height(50.dp)


ThomasSession · 2025-12-21T22:30:44Z

app/src/main/java/org/thoughtcrime/securesms/mediasend/MediaPickerFolderAdapter.java

 import java.util.ArrayList;
 import java.util.List;

+@Deprecated


One thing to be mindful of if you decide to keep all the old stuff, is to not forget to clean it out later.
With git history you can easily access old files you should be ok deleting and cleaning everything you don't need anymore.
Don't forget to clean out the layout.xml files, and possibly unused views.xml, dimensions, etc...

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+            .clickable(onClick = onClick)
+    ) {
+        Box(modifier = Modifier.aspectRatio(1f)) {
+            GlideImage(


ThomasSession · 2025-12-21T22:42:14Z

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+                modifier = Modifier.fillMaxSize(),
+                contentScale = ContentScale.Crop
+            )
+            // Bottom shade overlay


Do you think it could be achieved more easily with the innerShadow modifier?

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+        selected.indexOfFirst { it.uri == media.uri }
+    }
+
+    // Matches adapter rules:


app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+            .padding(end = 2.dp, bottom = 2.dp)
+            .aspectRatio(1f)
+            .combinedClickable(
+                onClick = {


app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+
+    Box(
+        modifier = modifier
+            .padding(end = 2.dp, bottom = 2.dp)


app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+        )
+
+        // Border overlay (replaces @drawable/mediapicker_item_border_dark View)
+        Box(


app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+                    painter = painterResource(R.drawable.triangle_right),
+                    contentDescription = null,
+                    modifier = Modifier
+                        .size(width = 15.dp, height = 18.dp)


jbsession · 2026-01-08T16:15:04Z

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/MediaPickerFolderScreen.kt

+
+    val context = LocalContext.current
+    val activity = context as? FragmentActivity
+    val showManage = remember(activity) {


I moved a few functions into the VM and added the flag to the UiState as an initial change. Maybe we can separate permission checking from the AttachmentManager. I copied some of the permission checks into the VM for now but I can do the separate file if we find that suitable for the modern structure.

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/MediaPickerFolderScreen.kt

+                    .fillMaxSize()
+                    .background(LocalColors.current.background)
+            ) {
+                items(folders) { folder ->


app/src/main/java/org/thoughtcrime/securesms/ui/theme/Dimensions.kt

+    val mediaItemGridSpacing : Dp = 2.dp,
+    val mediaPlayOverlay : Dp = 36.dp,
+
+    val smallRadius : Dp = 26.dp


app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+                        .padding(LocalDimensions.current.xxsSpacing),
+                    contentAlignment = Alignment.Center
+                ) {
+                    IndicatorOn(size = LocalDimensions.current.smallRadius)


app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

+import androidx.compose.ui.tooling.preview.Preview
+import androidx.compose.ui.unit.Dp
+import com.bumptech.glide.integration.compose.ExperimentalGlideComposeApi
+import com.bumptech.glide.integration.compose.GlideImage


ThomasSession · 2026-01-07T23:24:28Z

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

            .aspectRatio(1f)
+            .border(
+                width = LocalDimensions.current.borderStroke,
+                color = Color.White.copy(alpha = 0.20f)


A new color is suspicious here. Shouldn't it be our LocalColors.current.borders color instead?

@jbsession You added the new color but you left the alpha. Is that needed? The border colour alone should be enough?

jbsession added 3 commits December 18, 2025 12:11

Initial MediaPickerFolder and MediaPickerItem compose

5c3c296

Initial fragment changes, ComposeViews and minor VM updates

5ac12ef

Fixed wrong flag set

414feed

jbsession self-assigned this Dec 19, 2025

SelectionOverflow error

0e69415

ThomasSession reviewed Dec 21, 2025

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt Outdated

modifier = Modifier

.align(Alignment.BottomCenter)

.fillMaxWidth()

.height(50.dp)

This comment was marked as resolved.

Sign in to view

ThomasSession reviewed Dec 21, 2025

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt Outdated

.clickable(onClick = onClick)

) {

Box(modifier = Modifier.aspectRatio(1f)) {

GlideImage(

This comment was marked as resolved.

Sign in to view

ThomasSession reviewed Dec 21, 2025

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt Outdated

selected.indexOfFirst { it.uri == media.uri }

}

// Matches adapter rules:

This comment was marked as resolved.

Sign in to view

ThomasSession reviewed Dec 21, 2025

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt

.padding(end = 2.dp, bottom = 2.dp)

.aspectRatio(1f)

.combinedClickable(

onClick = {

This comment was marked as resolved.

Sign in to view

ThomasSession reviewed Dec 21, 2025

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt Outdated

Box(

modifier = modifier

.padding(end = 2.dp, bottom = 2.dp)

This comment was marked as resolved.

Sign in to view

ThomasSession reviewed Dec 21, 2025

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt Outdated

)

// Border overlay (replaces @drawable/mediapicker_item_border_dark View)

Box(

This comment was marked as resolved.

Sign in to view

ThomasSession reviewed Dec 21, 2025

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt Outdated

painter = painterResource(R.drawable.triangle_right),

contentDescription = null,

modifier = Modifier

.size(width = 15.dp, height = 18.dp)

This comment was marked as resolved.

Sign in to view

ThomasSession reviewed Dec 21, 2025

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/MediaPickerFolderScreen.kt Outdated

.fillMaxSize()

.background(LocalColors.current.background)

) {

items(folders) { folder ->

This comment was marked as resolved.

Sign in to view

jbsession added 2 commits January 7, 2026 11:26

Updated hardcoded dimensions, other compose changes

76fd508

Moved most logic to viewmodel

6ced08d

ThomasSession reviewed Jan 7, 2026

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/ui/theme/Dimensions.kt Outdated

val mediaItemGridSpacing : Dp = 2.dp,

val mediaPlayOverlay : Dp = 36.dp,

val smallRadius : Dp = 26.dp

This comment was marked as resolved.

Sign in to view

ThomasSession reviewed Jan 7, 2026

View reviewed changes

app/src/main/java/org/thoughtcrime/securesms/mediasend/compose/Components.kt Outdated

.padding(LocalDimensions.current.xxsSpacing),

contentAlignment = Alignment.Center

) {

IndicatorOn(size = LocalDimensions.current.smallRadius)

This comment was marked as resolved.

Sign in to view

ThomasSession reviewed Jan 7, 2026

View reviewed changes

jbsession added 2 commits January 8, 2026 10:48

Dimensions file and compose cleanups

0a94f61

initial update to checking permission

794a101

MediaSend update 1 : Moved fragment UI to compose #4

Are you sure you want to change the base?

MediaSend update 1 : Moved fragment UI to compose #4

Uh oh!

Conversation

jbsession commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThomasSession Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

ThomasSession Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

ThomasSession Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

jbsession Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

ThomasSession Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

ThomasSession Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jbsession commented Dec 19, 2025 •

edited

Loading