Skip to content

SonarQube #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jd-apprentice merged 2 commits into from
Feb 28, 2025
Merged

SonarQube #100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72a1a62
style: sonarqube security
jd-apprentice Feb 28, 2025
0a8dd70
style: sonarqube security
jd-apprentice Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/image/image-repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,21 @@ class ImageRepository {
* @return { Promise<ImageProp> } - A new image created
*/
async create(image: ImageProp): Promise<ImageProp> {
const sanitizedTagId = image.tag.toString().trim();
if (!Types.ObjectId.isValid(sanitizedTagId)) {
rollbar.error('Invalid tag id');
const sanitizedTagId = image.tag.tag_id?.toString();
if (!Types.ObjectId.isValid(image.tag.tag_id)) {
throw new Error('Invalid tag id');
}

const tagExists = await Tag.findOne({ tag_id: sanitizedTagId });
const _idTag = tagExists?._id;
const tagExists = await Tag.findById({ tag_id: { $eq: sanitizedTagId } });

if (!tagExists) {
rollbar.error('Tag not found');
throw new Error('Tag not found');
}

return Image.create({
...image,
tag: _idTag ?? image.tag, // Use validated tag or fallback
tag: tagExists._id,
});
}

Expand Down