Skip to content

Conversation

@anthony0030
Copy link

like previous pull request but with a bug removed and better quote styling

… them been round

Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
…s the author made it

Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
@JaviLopezM
Copy link

Great job! but how I can do to put only corner the top of the bars If I have 2 charts in the same bar?

@anthony0030
Copy link
Author

Could you please send me a link to a minimum production repository so I can take a look

@tamirgilany
Copy link

tamirgilany commented May 14, 2019

I added it to my project and I see that there is a performance issue. Running it on list of 90 items. Also fullCornerRadius isn't really full and missing the bottom left corner.

@anthony0030
Copy link
Author

Could you please set up a minimum code example so I can take a look

@tamirgilany
Copy link

Buggy Version:
https://plnkr.co/edit/IPDrmTyh0BroOdURXfKy?p=preview

Working Version:
https://plnkr.co/edit/8DCSdOS5Y2VOZUePsNHx?p=preview

You can play with it and see the that animation on the first one is having some lag issues.

@anthony0030
Copy link
Author

I see the problem when I enable CPU throttling in the chrome tools.
Thank you for setting up the demos.
I made this pull request as part of a project from Treehouse.
The developer that this repo belongs to seems not to have committed anything for a while.
Do you have any suggestions on how to fix the problem?
would you like to fix the problem with me ?

@tamirgilany
Copy link

Thank you for your answer.
I can try to help out :)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants