make webhook url configurable#310
Open
lifeofguenter wants to merge 8 commits intojenkinsci:masterfrom
Open
Conversation
jglick
approved these changes
Jan 6, 2021
Member
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
IIUC the patch is fine but the PR title is misleading: -Djenkins.hook.url=https://the.proxy/ already works for register, just not for unregister.
| rootUrl = Jenkins.get().getRootUrl(); | ||
| } | ||
| if (rootUrl == null) { | ||
| return rootUrl; |
Member
There was a problem hiding this comment.
Suggested change
| return rootUrl; | |
| return null; |
(for clarity)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in certain setups we separate jenkins from private/public network. We do setup a reverse proxy though for webhooks from public to work. That however means that we need to let jenkins register the public url, instead of the private url.
Fortunately, this is already half-way supported (though most prolly for a different use case).