Skip to content

Conversation

@PeterCardenas
Copy link
Contributor

PR Description

closes #4581

when pressing the remove keymap for files, we now group them up by the action we will perform on them, and then execute each action in bulk for all the files. This is a much faster approach than executing for each file.

some notes:

  • was initially fully generated by ai, i fixed it up a decent amount but the logic still seems a bit wonky, will review more once i get a chance
  • the discard unstaged files logic can be a separate change if need be, ai went ahead and did both to begin with so figured i'd go with it
  • trusting that existing integration tests and unit tests are good enough since this is not new behavior, but open to adding more

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)* [x] Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@PeterCardenas PeterCardenas force-pushed the batch-file-remove-action branch from 7ccf17a to d4b9643 Compare December 5, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discard changes can be very slow

1 participant