Fix to support creating MRs for repositories cloned with SSH alias #5082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Use case: some repositories are cloned with a full SSH alias (without a user). E.g. in
.ssh/configyou haveand then you clone with
git clone gitlab:foo/barAccording to the docs, you can add a service to
config.yamland it should work:But currently it doesn't because lazygit expects all remote URLs to have a user. This can be fixed by the user by changing the URL to e.g.
git@gitlab:foo/bar, but it breaks the user flow and is quite unexpected.This PR changes
defaultUrlRegexStringsand makes theuser@part of the remote URL optional. Fixes the issue for Github and Gitlab which use the default regexes.Please check if the PR fulfills these requirements
go generate ./...)