Prevent lazygit crashing for some xcbuild metadata #5085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When nix brings in xcbuild as a transitive dependency on macOS, if there are new metadata tags that the nix-specific version of xcbuild doesn't support, then `git status` will write a warning to stderr like: `warning: unhandled Platform key FamilyDisplayName`. That stderr message causes lazygit to crash. My fix is to filter out the warnings and then redirect them to the lazygit log Fixes jesseduffield#5013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nix brings in xcbuild as a transitive dependency on macOS, if there are new metadata tags that the nix-specific version of xcbuild doesn't support, then
git statuswill write a warning to stderr like:warning: unhandled Platform key FamilyDisplayName. That stderr message causes lazygit to crash. My fix is to filter out the warnings and then redirect them to the lazygit logFixes #5013
PR Description
Please check if the PR fulfills these requirements
go generate ./...)[ ] Text is internationalised (see here)[ ] If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)[ ] Docs have been updated if necessary