Open
Conversation
|
This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-) |
Contributor
Author
|
Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens #109 which was merged in error
Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url
Summary of Changes
So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??
Testing Instructions
Code Review
Documentation Changes Required
Not really