[4.0] Change access to body of Response object#62
Merged
Hackwar merged 2 commits intojoomla-framework:4.x-devfrom Aug 6, 2025
Merged
[4.0] Change access to body of Response object#62Hackwar merged 2 commits intojoomla-framework:4.x-devfrom
Hackwar merged 2 commits intojoomla-framework:4.x-devfrom
Conversation
richard67
reviewed
Aug 6, 2025
richard67
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When converting the code to v4 of the Joomla HTTP package, the method
Response->getBody()->getContents()was used to access the body of the response, which can be problematic, when the pointer of the internal stream is not set to the beginning. This PR changes the code to use the magic__toString()method of theStreamInterfaceinstead.Testing Instructions
Codereview
Documentation Changes Required
none