Skip to content

Updating "Also in" link styles for better usability #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgol merged 2 commits into from
Apr 14, 2025
Merged

Updating "Also in" link styles for better usability #480

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bdd300
Updating "Also in" link styles for better usability
aldimar-junior Apr 8, 2025
f7e4e85
Removing ruleset that would be empty otherwise
aldimar-junior Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions themes/jquery/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,7 +1970,7 @@ footer .books li a cite {

.entry-meta,
.entry-posted {
color: #999;
color: #666;
Copy link
Member

@mgol mgol Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used on multiple pages - entry-meta on some API metadata and entry-posted on metadata for blog posts, but both seem fine to me to change 👍🏻.

font-size: 12px;
}

Expand Down Expand Up @@ -2043,8 +2043,8 @@ footer .books li a cite {
}

.listing #content .entry-meta .category a {
color: #888;
text-decoration: none;
color: #0769ad;
text-decoration: underline;
Copy link
Member

@mgol mgol Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove these styles? I think these are the defaults for links here?

Copy link
Contributor Author

@aldimar-junior aldimar-junior Apr 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure, I think we can remove the ruleset:

.listing #content .entry-meta .category a {
	...
}

entirely since it will have nothing inside of it and having empty rulesets is not a good practice.

Copy link
Contributor Author

@aldimar-junior aldimar-junior Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?

Copy link
Member

@mgol mgol Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that'd be my preference - if that works; I haven't checked if other rules are not overriding this otherwise.

Copy link
Contributor Author

@aldimar-junior aldimar-junior Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and it worked fine, I'll make a new commit removing the ruleset.

}

.pagination {
Expand Down