fix: disable escaping in Jetty logging for executable wars by default #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlwilson
force-pushed
the
disable-log-escaping
branch
from
e8619fc to
56d4d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #589 to make the default std err logs more usable
jruby-rack and jruby in general can often log large backtraces and such inside logging messages, which Jetty's default stderrlog will escape in a way that makes them unreadable.
Users who need a "proper" logging solution are better to switch to SLF4J logging anyway, which requires a jar implementation to be added into warbler and some
webserver.propertiesconfiguration. We can address this to work-by-default for a Jetty 10+ upgrade where this older StdErr logging approach is gone (see jetty/jetty.project#4572).